search

fgacyc / erp-deprecated

0 stars 0 forks source link

added cyc id in account setting modal #14

Closed xylim98 closed 1 year ago

xylim98 commented 1 year ago

Please tell us what you did

1. Added CYC ID in UI_SettingModalLeft.jsx
2. Added CYC ID in SettingModalAccount.jsx
3.
4.

Are there any concerns that may be raised ?

Please add which issue does this PR close below using ("closes #issue_number")

12

ETCasual commented 1 year ago

Hi sorry just checking did @Dorothea303 assigned u on this?

xylim98 commented 1 year ago

Nope, I self-asign since @yuenci description seems to be clear and straight forward

ETCasual commented 1 year ago

Oh ok cuz right now we are almost done with migrating from JavaScript to TypeScript, so to push new changes to the code would need to wait for the task to be completed as it would introduce breaking changes to the code

Ill merge this when the migration task is done

xylim98 commented 1 year ago

oh i c, ok.

ETCasual commented 1 year ago

@xylim98 can u rewrite ur components into .tsx variants? Then ill review and merge it

xylim98 commented 1 year ago

@xylim98 can u rewrite ur components into .tsx variants? Then ill review and merge it

Already in tsx from 7c4465e right?

ETCasual commented 1 year ago

Yup yup, just need to change the logical and with logical or then its good to go