fgacyc / erp-deprecated

0 stars 0 forks source link

Remove old authenticatio #25

Closed yuenci closed 1 year ago

yuenci commented 1 year ago

Please tell us what you did

1. "/login" navigate to "/"
2. Remove authentication detection on frame
3. Create mock user data on status container(ModalStore)

Are there any concerns that may be raised ?

No

Please add which issue does this PR close below using ("closes #issue_number")

closes #24

yuenci commented 1 year ago

I don't think we should also remove all api calls now, we don't have any api calls about user auth any more, so we can start to integrate Auth0 to ERP. Other api calls all about recruitment, we will deal with recruitment later

ETCasual commented 1 year ago

also , run yarn lint before u commit so u know where else has issues

I don't think so, we don't have any api calls about user auth any more, so we can start to integrate Auth0 to ERP. Other api calls all about recruitment, we will deal with recruitment later

Okay, btw, ive pulled ur branch, and it seems like there are some type mismatch, im gonna fix it and also because of this i realised theres a need to check type errors, im gonna add a precommit check as well