Modesearch defaults - Githubissues

fgasdia / LongwaveModePropagator.jl

Model the propagation of VLF radio waves in the Earth-ionosphere waveguide.

https://fgasdia.github.io/LongwaveModePropagator.jl/dev

MIT License

15 stars 5 forks source link

Modesearch defaults #37

Closed fgasdia closed 3 years ago

fgasdia commented 3 years ago

Closes #36

Introduces breaking changes that: 1) Increases default LMPParams().integrationparams.tolerance and 2) removes filtering of modes based on satisfying the mode condition (the previous filtering tolerance was regularly removing valid modes when this should be handled by RootsAndPoles.jl).

fgasdia commented 3 years ago

So far this:

Removes filterroots! filtering of candidate mode solutions
Changes uniqueness criteria of candidate mode solutions to one digit fewer than GRPF tolerance (down from two digits)
Changes default integrationparams tolerance to 1e-5 (from 1e-8)
Changes default wavefieldintegrationparams solver to Tsit5 (from Vern7) and tolerance to 1e-6 (from 1e-8)

fgasdia commented 3 years ago

This PR now

Refines Δr_fine to deg2rad(0.1) (from deg2rad(0.15)) in defaultmesh (and used by findmodes), which increases robustness for some reasonable, non-exponential ionospheres.