search

fgci-org / ansible-role-slurm

For installing and configuring SLURM - Simple Linux Utility for Resource Management
MIT License
34 stars 15 forks source link

Support for SLURM version specific settings in slurm and slurmdbd.conf #94

Closed martbhell closed 6 years ago

martbhell commented 6 years ago

With this PR this ansible-role now supports setting vars by default in slurmdbd.conf and slurm.conf for some SLURM versions. Already before a user of this role could set ansible variable {{ slurm_ExtraParamsList }} and it would add those to slurm.conf

Together with the above changes we with SLURM 17.11 (only) now set slurmdbd, slurmctld and slurmd syslog levels to "info" rather than the default "quiet" or "fatal".

The reason why the settings are not added into slurm.conf is because slurm does not start with unknown parameters in slurm.conf - it would have broken backwards compatibility with versions prior to 17.11.

Some background information: https://bugs.schedmd.com/show_bug.cgi?id=4514

martbhell commented 6 years ago

I'm now fairly happy with this PR and is humbly requesting a review.

jabl commented 6 years ago

I guess this is fine, yes.