Ansible updated => lots of spam

[jabl]

Seems ansible in EPEL got updated to version 2.0.1. Stuff seems to work, but there are a lot of warnings like

[DEPRECATION WARNING]: Using bare variables is deprecated. Update your playbooks so that the environment value uses the full variable syntax ('{{autofs_indirect_maps}}'). This feature will be removed in a 
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

Someone should go through all the roles and fix these warnings..

[jabl]

Another common warning

[DEPRECATION WARNING]: Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' (default). This feature will be removed in a future release. Deprecation warnings can be 
disabled by setting deprecation_warnings=False in ansible.cfg.

[martbhell]

Finally! The travis tests can help with this: https://travis-ci.org/CSC-IT-Center-for-Science/ ( maybe even check the "devel" build which tests ansible 2.1(master).

[martbhell]

Best way to find all of these was with a "grep -R with_items: " in fgci-ansible. Travis helped with testing for syntax errors. Next fgci-ansible release should have all these fixes..

[martbhell]

Phew. Lots of updates here. Another error:

TASK [network_interface : Create the network configuration file for vlan devices] ***
[DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this will be a fatal
 error.. This feature will be removed in a future release. Deprecation warnings can be disabled
 by setting deprecation_warnings=False in ansible.cfg.

[martbhell]

undefined Errors from network_interfaces is fixed in b9de10bf6b16042e30202538219ef5cca7f7fedb . There's some errors regarding with_subelements in that role which is an ansible bug.

There's a lot of "sudo: yes" in roles and playbooks. Updating these too.

[martbhell]

This is mostly done now, marking as closed. A few warnings remaining where I'm not convinced they are actually errors. These two are seen from ansible-pull:

a) the dependency we have in the meta/ in ansible-role-slurm. b) network_interfaces role regarding a with_subelements

[jabl]

Thanks for all the work on this. One error I'm still seeing is when running tools/pullreq.sh:

- extracting ansible-role-fail2ban to roles/ansible-role-fail2ban
- ansible-role-fail2ban was installed successfully
- extracting ansible-role-slurm to roles/ansible-role-slurm
- ansible-role-slurm was installed successfully
[DEPRECATION WARNING]: The comma separated role spec format, use the yaml/explicit format instead.. This feature will be removed in a future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
- extracting ansible-role-cvmfs to roles/ansible-role-cvmfs
- ansible-role-cvmfs was installed successfully
...

This deprecation warnings always shows up when installing ansible-role-slurm. I don't really understand why, at least in requirements.yml there is nothing special about ansible-role-slurm..

[martbhell]

I think that is the a) I mentioned above

http://docs.ansible.com/ansible/playbooks_roles.html#role-dependencies has the same format we do. So maybe this is an ansible bug like this: https://github.com/ansible/ansible/pull/14612