fgci-org / fgci-ansible

:microscope: Collection of the Finnish Grid and Cloud Infrastructure Ansible playbooks
MIT License
54 stars 18 forks source link

Update NTP role - in preparation of ansible 2.2 #128

Closed martbhell closed 8 years ago

martbhell commented 8 years ago

The external ntp role is not updated for over a year: https://github.com/resmo/ansible-role-ntp

With ansible 2.2.0 (detached HEAD d81b9ca29e) last updated 2016/05/30 08:21:44 (GMT +000) we are seeing the below failures:

TASK [ansible-role-ntp : Start/stop ntp service] *******************************
task path: /ansible-role-ntp/tasks/main.yml:22
...
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_args": {"enabled": "yes", "name": "ntpd", "pattern": "/ntpd", "state": "started"}}, "msg": "unsupported parameter for module: pattern"}

2.2 in EPEL is quite far away (2.1 is not in there and that was only released a week ago). I think we should change this to a compatible role (compatible = we don't have to change any variables in fgci-ansible group_vars).

It might be that the pattern= missing in the 2.2.0's service module is an error and that this is an erroneous error. In either case it would be good to move to a maintained external role.

jabl commented 8 years ago

Probably this needs to change anyway in case we want to switch to chrony per https://github.com/CSC-IT-Center-for-Science/fgci-ansible/issues/103 ?

martbhell commented 8 years ago

Let's go with chrony instead. Ansible 2.2 has target September 2016, so it's about time to start using chrony. Continuing the work in #103