search

fgci-org / fgci-ansible

:microscope: Collection of the Finnish Grid and Cloud Infrastructure Ansible playbooks
MIT License
54 stars 18 forks source link

Replace wget with rsync in example group_vars #184

Closed jabl closed 7 years ago

jabl commented 7 years ago

Adding rsync is not strictly necessary, since it's pulled in as a dependency of git. But lets have it there anyway because it's needed for ansible-pull-script, just in case the dependency list of git changes or we decide we no longer need git in the default install.

jabl commented 7 years ago

Also, many (most/all?) roles install wget in tests/test-in-docker-image.sh, though AFAICS that's not related to ansible-pull-script.sh in any way?

martbhell commented 7 years ago

Is there a reason why you'd want to not install wget?

$ rpm -q --whatrequires wget
no package requires wget

-- Yes, the tests/ and .travis.yml files are only used with travis and the testing. The centos docker image is minimaller.. than the normal minimal install. In most roles I've recently been changing to not use the "function install_ansible_devel()" but rather in the tests/$/Dockerfile install it from epel, pip or compile it from rpm.

jabl commented 7 years ago

No particular reason except why install it if it's not needed by anything?

OTOH, since we've had wget since the beginning maybe some of our users are depending on its presence, so hmm, maybe we should still keep it? It's not a particularly large package after all..

martbhell commented 7 years ago

At least I use it sometimes :)

martbhell commented 7 years ago

Closing and adding rsync in all the places.