fgcz / prolfqua

Differential Expression Analysis tool box R lang package for omics data
https://pubs.acs.org/doi/pdf/10.1021/acs.jproteome.2c00441
MIT License
37 stars 7 forks source link

volcano plot with fixed ylim (scales) cannot be "freed up" with scales="free" #67

Closed jjGG closed 6 months ago

jjGG commented 6 months ago

Hoi Witold,

As you may have seen in the comments, one user SH realized that the volcanos are by default fixed on ylim. Relaxing this with the scales parameter does not work .

-> in all these volcanos, the y-axis always has the same fixed length. pl$volcano(scales = c("fixed")) pl$volcano_plotly(scales = "free") pl$volcano(scales = "free") pl$volcano(scales = "free_y")

Gruess & bis am Dienstag j

wolski commented 6 months ago

@jjGG

I did run the examples in the prolfqua package ContrastsPlotter documentation:

cp$volcano(scales = "fixed")

image

cp$volcano(scales = "free")

image

Please try to reproduce an possible error using any of the example datasets provided with prolfqua.

wolski commented 6 months ago

@jjGG

I did limit the p.values to a minimum of 0.0001 ... Now, there is a parameter minscorein the volcano function, which you can set to whatever you want.

jjGG commented 6 months ago

@wolski - super cool. Thanks for tghe fix!

jjGG commented 6 months ago

Hei Witold,

Leider funktioniert bei mir (prolfqua 1.1.5) der minscore parameter nicht. Eine Idee?

v3 <- plotter$volcano(minscore=c(1E-10))
Error in plotter$volcano(minscore = c(1e-10)) : 
  unused argument (minscore = c(1e-10))
jjGG commented 6 months ago

Super - Danke Witold.

Hat funktioniert. RTFM! minscore =/ min_score

plotter <- contr$get_Plotter()
v2 <- plotter$volcano()
gridExtra::grid.arrange(v1$FDR,v2$FDR, ncol = 1)

# relax ylim
v3 <- plotter$volcano(min_score=1E-10)

gridExtra::grid.arrange(v2$FDR,v3$FDR, ncol = 1)

image