When deploying rest services the modules should installed relative to /root

fgeorges / mlproj-core

Core implementation of mlproj, everything not TUI-related

Apache License 2.0

1 stars 2 forks source link

When deploying rest services the modules should installed relative to /root #21

Closed eurochriskelly closed 7 years ago

eurochriskelly commented 7 years ago

Given the structure:

ml-modules\
   root\library.sjs
   services\endpoint.sjs

... if I deploy a source of type rest-srv with dir=ml-modules, it will install the library to /root/library.sjs. To be compatible with gradle, it should install to /libary.sjs.

eurochriskelly commented 7 years ago

Current workaround is to deploy the libraries in a separate step using a named source. This are the run in series using npm-run-all and combining npm scripts.

fgeorges commented 7 years ago

Thank you, @eurochriskelly

For now, the definition of rest-src is:

services/* are installed as REST extensions
transforms/* are installed as REST transforms
everything else is deployed "as is"

and you suggest we replace last point by:

root/* are deployed as a plain source set on its own
everything else is an error

Correct?

fgeorges commented 7 years ago

Related to #20 (which is about first deploy root/, then look at services/ and transforms/).

fgeorges commented 7 years ago

Should be fixed in latest mlproj, 0.46.5. @eurochriskelly, can you check and close the issue?

eurochriskelly commented 7 years ago

These are installed in the expected location now. Thanks!