search

fgeorges / mlproj-core

Core implementation of mlproj, everything not TUI-related
Apache License 2.0
1 stars 2 forks source link

Can't change port #3

Closed eurochriskelly closed 7 years ago

eurochriskelly commented 7 years ago

I tried changing the port but I get this message:

Error: Property differ but is frozen on abc: port

Any reason why this is not allowed?

fgeorges commented 7 years ago

There are 2 frozen properties: the server type (HTTP, XDBC...) and its port.

For the type, it is forbidden by the Management API. I think the reason why I froze the port was because it requires a restart, and wanted to make sure I handle it properly before allowing it.

Can you try and remove .freeze() in src/properties.js on line 510, and see if it works for your use case?

fgeorges commented 7 years ago

The port was frozen because it makes MarkLogic restart.

I have implemented waiting for MarkLogic when necessary, on a property change. And I unfroze the property port.

This is available in 0.31.0, which has been published on NPM. Can you update and try it, please?

eurochriskelly commented 7 years ago

This works now. Thanks!