fgilde / MudBlazor.Extensions

MudBlazor.Extensions from https://www.mudex.org is a small extension for MudBlazor from https://mudblazor.com
http://www.mudex.org
MIT License
242 stars 20 forks source link

[Bug]: Multiple non-modal dialogs closing issue #42

Open Filip00007 opened 1 year ago

Filip00007 commented 1 year ago

What happened?

While poping-up multiple non-modal dialog windows and closing them in different order than it was opened causes user to click two times on X icon (or close button) and also new dialog reappears...

Expected Behavior

Closing multiple dialog windows should not be dependent on order of theirs opening and aslo should not cause automatic reopening of a new dialog...

Screenshots

https://github.com/fgilde/MudBlazor.Extensions/assets/134936703/9f874006-a246-46c7-9dd7-2971f2d5fcf4

What application type are you referring to?

ServerRendered

Custom Application Type

No response

MudBlazor.Extension Version

1.7.66

MudBlazor Version

6.9.0

What browser are you using?

Chrome

Sample Solution

No response

Pull Request

No response

Code of Conduct

fgilde commented 1 year ago

will have a look at this.

fgilde commented 1 year ago

I fixed the direct interaction with the buttons on first click. But the other problem I cant solve currently without a good idea and its still an open issues. Problem is when closing in the same reverse order everything works fine. But with other order MudBlazor forces a statechange and whole ui regenerates what causes new reference elements for the dialogs and the dialogs itself. To solve this I reinit the dialog options on js side currently and this resets the last sate. Maybe i need to find a better way, but currently i didnt have an idea.

Last changes are deployed in 1.7.67

SpikeThatMike commented 2 months ago

I also have an issue similar to this. When opening two dialogs in non-modal mode & resizable, lets say dialog 1 and dialog 2.

if I open dialog 1 then open up dialog 2, I can move them both. If I then close dialog 2 (the most recent opened one) I can still move dialog 1 around & resize it. However if I did it the other way around so I close dialog 1 first, dialog 2 doesn't let you move or resize it

Alexr03 commented 2 months ago

Am also running into this problem, would love for this to be looked at for a fix again 🙏🏼

M0RG4N01 commented 2 months ago

I face the same issue and would really like to use non-modal because its great to have multiple dialogs open. If I do as the creator mentioned and close dialogs in the perfect reverse order its great; otherwise, it'll bug out.

fgilde commented 2 months ago

I will check again what I can do to solve it. Maybe need to create a Pull Request in MudBlazor because there is the event handling that forces this issue

Alexr03 commented 2 months ago

I will check again what I can do to solve it. Maybe need to create a Pull Request in MudBlazor because there is the event handling that forces this issue

Thanks for taking another look at this! :D If you need me to test any changes let me know.