search

fgilde / MudBlazor.Extensions

MudBlazor.Extensions from https://www.mudex.org is a small extension for MudBlazor from https://mudblazor.com
http://www.mudex.org
MIT License
245 stars 20 forks source link

Fix validation for MudExUploadEdit and remove unneeded MudExValidationWrapper. #63

Closed JaronMLifsey closed 1 year ago

JaronMLifsey commented 1 year ago

Form validation for MudExUploadEdit wasn't working for me. I might have misled you a bit with the wrapper example in the feature request. I got it working locally and thought I'd send it your way to review and if you like, integrate.

I deleted the wrapper class as it looked like you added it just for this.

I also threw a small rendering change in there. Instead of using MudGrid with each item being full width, I swapped to MudStack. MudGrid uses negative margin which causes an internal scroll bar some times. You can see it when hovering a dragged file over the drop zone on the example site and it seems to manifest other times as well. The spacing is the same as before even though it was changed from 1 to 2 (It seems MudGrid doubles the spacing distance compared to MudStack when using the same value because adjacent pairs of items contribute their own padding to the space between them).

fgilde commented 1 year ago

Thanks for help. Looks good. But I added Validation Wrapper as Component again because I currently working on a Feature to remove the current Meta setting from MudExObjectEdit WithSeparateValidationComponent and want to create a wrapin ValidationComponent then instead.