Allow send() to skip appending newline at the end.

fgimian / paramiko-expect

A Python expect-like extension for the Paramiko SSH library which also supports tailing logs.

MIT License

205 stars 78 forks source link

Allow send() to skip appending newline at the end. #25

Closed mzagozen closed 7 years ago

mzagozen commented 7 years ago

Sometimes, you only want to send a control character (Ctrl-C) without a newline.

This PR adds a new optional newline boolean parameter to the send() method to override the default behavior.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 99.185% when pulling e93579bc0130deec5c97de3f233bad0b5c2009d1 on mzagozen:master into dda719fe627a5b8c2a1f80b50e25b072de98d24a on fgimian:master.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 99.638% when pulling 11560dbb2a3b22314659731189b9a4ce74fb6bdb on mzagozen:master into dda719fe627a5b8c2a1f80b50e25b072de98d24a on fgimian:master.

mzagozen commented 7 years ago

This is odd. I added a test case that works on my machine, but fails in travis. I'm running the tests locally with pytest -s --cov paramiko_expect --cov-report term-missing.

Any ideas @fgimian?

fruch commented 7 years ago

@mzagozen thanks for you input please see my comments

as for testing in CI, what did you expect to happen ?

fruch commented 7 years ago

after looking into the CI jobs, it's not your fault it was failing the docker image I was using there was renamed, I'll deliver a fix to master soon...