search

fgimian / paramiko-expect

A Python expect-like extension for the Paramiko SSH library which also supports tailing logs.
MIT License
204 stars 78 forks source link

Issue #84 - Apply timeout removal on Windows when going interactive #85

Closed karypid closed 2 years ago

karypid commented 2 years ago

After looking at threading code, it seems that None is the value that should work for both Windows and Linux, but I am only adding it for the Windows case to make sure nothing else breaks.

This fixes #84 (tested on my Windows 11 system).

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (af9c5b8) into master (a485a8a) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%     
==========================================
  Files           1        1              
  Lines         155      156       +1     
==========================================
+ Hits          151      152       +1     
  Misses          4        4
Impacted Files Coverage Δ
paramiko_expect.py 97.43% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a485a8a...af9c5b8. Read the comment docs.

fruch commented 2 years ago

@karypid thanks for the fix