fgl27 / SmartTwitchTV

A Twitch web client that works on Android TVs and web base systems
GNU General Public License v3.0
366 stars 28 forks source link

Video preview / video thumbnail placement bug #181

Open androgeosone opened 1 year ago

androgeosone commented 1 year ago

I am experiencing a bug where preview videos / thumbnail videos and split-screen videos are wrongly sized and wrongly placed. It appears that the videos to the right of the screen are further misplaced, which videos near the left are nearly correctly placed (but still wrong). In split-screen, there are big gaps between views.

Full screen playback of a single stream works perfectly - only smaller than full screen playback has wrong size/placement.

To Reproduce Steps to reproduce the behavior:

  1. Install SmartTwitchTV APK on android TV device.
  2. Open the app (with default settings).
  3. Videos are placed wrong on the live channel list (and other lists).
  4. Deleted app and re-installed to make sure my settings are not the problem. Problem persists with default settings too.

Expected behavior The video previews are in the wrong place and wrong size. The preview videos are increasingly wrongly placed as they are further to the right of the screen.

Screenshots IMG_20230927_153205 IMG_20230927_153217 IMG_20230927_153235 IMG_20230927_153243 IMG_20230927_153249 IMG_20230927_153253 IMG_20230927_153259 IMG_20230927_153313 IMG_20230927_153319 IMG_20230927_153348 IMG_20230927_153405 IMG_20230927_153409 IMG_20230927_153418 IMG_20230927_153429

I have uploaded many screenshots to my google drive: https://drive.google.com/drive/folders/1QR3hF_D_kMFY2OzXQW4p4uRaBSMfS3Hs?usp=sharing

Device:

Additional context I have tested with all quality set to source and multiplayer/preview limits set to unlimited in case the scaling is causing problems, but still the thumbnails are in the wrong parts of the screen. My old android TV box worked perfectly, but that one ran at 1080p - I have since upgraded to a new 4K box and it has this problem - so maybe this is 4K specific?

I have also tried enabling and disabling the "Multiplayer, PP and preview mode workaround" option but it makes no difference.

fgl27 commented 1 year ago

The problem is that the Android device is reporting wrong screen size values, which affects position.

Next day I have some time will share a debug app that can display some information about the sizes reported to see if any helps.

The option "Multiplayer, PP and preview mode workaround" isn't for size fix, but prevents blank or invisible players.

androgeosone commented 1 year ago

Wow, thanks for such a fast reply.

I tested on two different devices: one android box, and also my chromebook. Both had this issue. It seems to be related to running at 4K. Previously I have used this app on several devices at 1080p with no problem like this ever before, but these are the only devices I have running android at 4K and both have this problem.

I am happy to give any diagnostics that might be helpful to debug this.

fgl27 commented 1 year ago

Can you try to set the devices to 1080p?

As this isn't an app problem with 4k, the app has existed for years and no one has ever complained.

I personally already tested many different devices and configurations including on 4k devices without any problem.

androgeosone commented 1 year ago

I can't change resolution on my box for some reason. Either my TV or my AV receiver is interfering with the resolution change - No idea why. I'll try again when I have more spare time this weekend since I will have to get the cables out from behind.

Meanwhile, on my chromebook outputting to the TV it works correctly at 1080p. If there is an offset to the video placement, it is not big enough to notice. Also, even at 4K, if I split screen with two apps, the smaller window view works correctly in both the preview mode and in split-screen.

IMG_20230927_194912 IMG_20230927_194959

androgeosone commented 1 year ago

OK, I finally managed to find some time to move all the cables to try different displays and devices together.

Basically, only 4K resolution is affected - scaling does not seem to matter. If the UI is rendered at 2160p the video is offset. If the UI is rendered at 1080p (even if the output is 4K) the offset is gone.

This seems to be consistent across devices, tested on an rk5588s Android box, an Intel i7-1167G7 powered Chromebook running Android and also a Dell optiplex 3000 i5-12400T Micro running BlissOS. Rendering at 4K offset - Rendering UI at 1080p (even if outputting 4K) no offset.

In the meatime, I have become so annoyed with Twitch ads that I switched to the purple tv app instead since I could not find a way to proxy or block ads with this one. I hope that helps debug this, but for now I wont be using this one anymore as the ads are unbearable.