search

fgl27 / smarttv-twitch

Twitch client for Samsung Smart TVs 2015 and newer models, in doubt read the README bellow
GNU General Public License v3.0
170 stars 18 forks source link

stream playback won't be resumed if two or more ads are pending to be shown #241

Open ancho85 opened 2 years ago

ancho85 commented 2 years ago

Describe the bug While watching a stream, if there is a trigger to show only one video ad then the stream is resumed without problems. However there are cases when two or more, one after the other must be shown. The first ad is shown and then the screen becomes black showing the loading animation. Nothing else can be seen, the chat is still being streamed to screen. The only way out of it is by exiting and reentering the app. This also retrieves the next ad and the same problem occurs (I yet again have to close the app and reopening, waiting if another ad or the stream can be resumed)

Expected behavior Show all ads one after the other then resume the stream.

Screenshots Video showing the behaviour https://user-images.githubusercontent.com/3135981/183432080-fb8f0821-921a-4934-858e-3cd3e31d9b74.mp4

Device: TV Model: UN50NU7095 Os version Tizen 4.0

Additional context I cannot control the ads being shown, or how many of them. It's not reproducible by my end only as it depends on the streamer and how many ads are set to be shown in a specific period of time.

fgl27 commented 2 years ago

This is a problem on yours TV, The player doesn't support this behavior.

On most TV this will not happen, without a problematic TV I can find a solution if one exist.

If you wanna to try to find a solution or something that helps post here wherever you can find.

fgl27 commented 2 years ago

I have add proxy support for the app

@ancho85 enable it on setting and let me know the result, TTV LOL proxy is out today but purple is OK.

image

ancho85 commented 2 years ago

I have add proxy support for the app

@ancho85 enable it on setting and let me know the result, TTV LOL proxy is out today but purple is OK.

Thank you! I will try this setting the whole weekend and let you know the results!

fgl27 commented 2 years ago

btw, I push a new update, that adds a proxy status to player status.

To receive the update if the app is open just force close the app by holding the return key, then just open the app.

If shows that the proxy server isn't working you can try a different option or just disable it all

image

ancho85 commented 2 years ago

I've tested for several days. This addition makes my watching experience truly great. I can see no longer any ads at all. The only time an ad showed was when, for some reason, the proxy was not connected. Thank you for the amazing work @fgl27!

fgl27 commented 2 years ago

That is great, thanks for the feedback.

The player status will tell you if the proxy fail, unfortunately proxy isn't perfect but at least we have two options, when one is down we can change to the other.

On my test TTV LOL is much faster at lest for me, it may be different for you as it dependes on you are in relation to the proxy.

fgl27 commented 2 years ago

Another thing I miss to inform... the Proxy can be control direct from the player, with makes easy change if one is malfunctioning, after select it is need to press enter to activate.

image

ancho85 commented 2 years ago

Another thing I miss to inform... the Proxy can be control direct from the player, with makes easy change if one is malfunctioning, after select it is need to press enter to activate.

image

That's a great addition! Thank you so much!

ancho85 commented 1 year ago

@fgl27 the only option that was left (TTV LOL) is not working anymore so this issue now comes again for me. Should I open a new ticket or this can be reopened?

fgl27 commented 1 year ago

Can leave this open. No solution for now.

If you know any working proxy solution or similar key me know.

ancho85 commented 1 year ago

Perhaps the Purple Ads Blocker extension for chrome has something you can use? There is a user script version.

fgl27 commented 1 year ago

Perhaps the Purple Ads Blocker extension for chrome has something you can use? There is a user script version.

you can see below, that the app already uses the extension as a proxy option, those extensions don't work anymore, at least not the integration with this app.

image

If you know a working solution you can share, but today I don't know one that works with this app, not all chrome extensions can be easily ported to work with this app, so just because one may work doesn't mean it will for this app use.

ancho85 commented 1 year ago

I remember there was that option but it dissapeared some time ago. It was removed because it stopped working, right? Or the now missing option is a bug? This extension was the only working option for twitch in a google chrome based browser.
image

fgl27 commented 1 year ago

I removed it as it no longer works on this app, the proxy implementation was disabled, I don't know if they have a proxy now, I believe they have something else, that isn't replicable on this app

fgl27 commented 1 year ago

If anyone know how those extensions work and wants to share please do I have limited time and some of those are quite complicated, so any help is welcome.