fgl27 / smarttv-twitch

Twitch client for Samsung Smart TVs 2015 and newer models, in doubt read the README bellow
GNU General Public License v3.0
169 stars 18 forks source link

VOD chat stream ends before it should #275

Open ancho85 opened 1 year ago

ancho85 commented 1 year ago

Describe the bug By watching a VOD and at the last 1 or 2 minutes the chat window informs 'The chat has ended', however by rewinding a couple of seconds the chat regains its correct stream as expected and ends when it really has to end.

To Reproduce Steps to reproduce the behavior:

  1. Go to any VOD with chat active until the very end of the stream
  2. See 'The chat has ended' before it actually ends
  3. Go back a couple of seconds, the chat reloads with the chat stream fixed

Expected behavior Chat should continue until the end

Screenshots

https://github.com/fgl27/smarttv-twitch/assets/3135981/fe340507-a066-416f-9a4a-5ad6106a07d6

In the video attached the chat shows this behavior, I'm going back 30 seconds and the chat resumes.

Device:

TV Model: UN50NU7095 Os version Tizen 1334

fgl27 commented 1 year ago

Can you share a vod that I can use to replicate?

ancho85 commented 1 year ago

The VOD used for the attachment is this https://www.twitch.tv/videos/1894307978

fgl27 commented 1 year ago

Will revise this and let you know.

fgl27 commented 1 year ago

I'm not able to reproduce this, is it still happening?

ancho85 commented 1 year ago

https://github.com/fgl27/smarttv-twitch/assets/3135981/0af103d3-8a91-4af2-91b5-53cff769e78c Yes, just tested again and it still happens. Maybe it won't happen if you fast forward to the end, but by watching it all it happens. This VOD shows the "chat ended" message 2 minutes before it actually ends.

fgl27 commented 1 year ago

OK will try again, thanks.

fgl27 commented 1 year ago

How many minutes from the end I can fast-forward to see the problem? I can't wat hours to see a problem

I tried a few things but it only works for me.

ancho85 commented 1 year ago

I'm thinking 5 minutes before it ends, however as I said, maybe that fast-fowarding to the end will make it sync and won't show the problem. I'll have to test it again by doing that.

fgl27 commented 1 year ago

Is very random, I tried a few vods, only one happened and is completely random, it happened once then no more...

so is the chat API that will just return the end sooner, sometimes, will see if I can reproduce it more to see if there is anything on the API answer that can help.

fgl27 commented 1 year ago

I have found something to improve, I assume it fixes the issue.

as is a little hard to test I assume, but please let me know if you see the behavior happening again.

ancho85 commented 1 year ago

Thank you! Will this require something to be updated on my end?

fgl27 commented 1 year ago

No, you just need to close the app and re open for it to update, in case it was open during the time I posted and now, if not you already received the update

ancho85 commented 1 year ago

Just tested and I can confirm the chat ended with the VOD as expected. Thank you Felipe