search

fgl27 / smarttv-twitch

Twitch client for Samsung Smart TVs 2015 and newer models, in doubt read the README bellow
GNU General Public License v3.0
171 stars 18 forks source link

Captions are forced on since last update. #287

Closed EtRnitY closed 10 months ago

EtRnitY commented 10 months ago

Is your feature request related to a problem? Please describe. Captions are auto enabled for streams who have them in their broadcast settings. Problem is I don't find a way to disable them in the settings or player. It wasn't happening before, I think it's since the last update, and only for streamers who have caption setting enabled, but not sure. App version : 4.0.1 December 01 2023

Describe the solution you'd like Perhaps adding a CC button to simply turn captions ON / OFF (like in the twitch app).

Describe alternatives you've considered I tried to hold UP button to reset config / settings, but it didn't change anything. My current settings are default and this still happens.

Additional context 20231213_140951

I don't know how to disable the captions at the top.

fgl27 commented 10 months ago

Seems a TV issue the app didn't changed anything regarding that

You can see here

https://github.com/fgl27/smarttv-twitch/blob/d797bcfbc7f6b1acc8f2f8cc71904c8186f47247/app/specific/Play.js#L1258

Is off by default reason described there.

Is that a live or vod?

Can you produce logs?

Here is the how to log

https://github.com/fgl27/smarttv-twitch/issues/250#issuecomment-1328306442

EtRnitY commented 10 months ago

It happens on LIVE or VOD, but only on some channels (depends if the streamer has captions activated in their settings I guess). Only streamer voice have captions, no other sound / voice (such as game voice) It doesn't happens on other apps, even official twitch app. Accessibility features are all OFF in my TV settings.

I tried to plug in my old usb fireTV to test the android smarttv app on my samsung TV, and eveything is fine. Problem only occur with the tizen version of smarttv-twitch.

Logs : in debug mode I searched for one of the streamer with caption ON, and started to watch a VOD

log2 log3 log6 20231214_193739

EDIT : I did a reset of my TV settings and restarded it and now everything is fine. I think this device (QN90B) has some captions grabber settings for apps that doesn't appear in accessibility-subtitles but somewhere else. It is possible this happened after a firmware update in november. It wasn't happening on android app on the same TV because I guess it's an external source and android have its own settings.