search

fgl27 / smarttv-twitch

Twitch client for Samsung Smart TVs 2015 and newer models, in doubt read the README bellow
GNU General Public License v3.0
171 stars 18 forks source link

Feature Request: Filtering out unwanted games #88

Open Albrektson opened 4 years ago

Albrektson commented 4 years ago

Please describe the feature. An option to ignore or filter out games, so that they don't show up on the main 'live' page.

Additional context or samples If you're not interested in a popular game, scrolling past all the top streams featuring it is a huge annoyance. The Chrome extension 'Unwanted Twitch' offers this feature for browsers, but I'd much rather keep using this app.

auto-comment[bot] commented 4 years ago

Thank you for raising a issue.
Make sure you follow the issue templates for yours type of issue see bellow.
Bug report:
https://github.com/fgl27/smarttv-twitch/blob/master/.github/ISSUE_TEMPLATE/bug_report.md
Etc issue that doesn't applies to features or bugs:
https://github.com/fgl27/smarttv-twitch/blob/master/.github/ISSUE_TEMPLATE/etc-related.md
Feature request new app feature:
https://github.com/fgl27/smarttv-twitch/blob/master/.github/ISSUE_TEMPLATE/etc-related.md
Feature request related to a problem:
https://github.com/fgl27/smarttv-twitch/blob/master/.github/ISSUE_TEMPLATE/feature-request-related-to-a-problem.md
Issue that don't properly fallow the templates can be close without any treatment.
I have sent an email to @fgl27 he will get back to you as soon as possible.

fgl27 commented 4 years ago

The filter doesn't exist, is not something that you can request from a Twitch API.

What can you request https://dev.twitch.tv/docs/v5/reference/streams#get-live-streams

there is a game filter but is wanted games not unwanted is not possible to put there more than one game so is not possible to put all but one or two and use that as a filter.

So this type of filter is needed to be done locally after the content has requested and loaded, with will require a change on how the app shows content and will cost processing time as the filter need to happens locally and will cause slowdown of the app to show the filtered content as it will only show after the filter has be applied, plus the interface to choose games to hide is a little odd to make and or control as is a lot to think on how implement it.

Because of that I will not make it is too much of work for a little featuring, that will make the app slow when used, for me a lose lose situation on my end I lost a lot time doing something that will make the app worst when used and can require future updates and updates to make it better is even possible, I can let this open as this is a open source app anyone can try to do it.

If you think that "'Unwanted Twitch'" extension does something that is cost effective, show me how it does, in code not in words, show me how they control the API or something like that to achieve the result in a eficiente way.