search

fgl82 / simplemenu

Simple menu launcher for the new Bittboy, Pocket Go, RetroFW and OpenDingux devices
156 stars 40 forks source link

Volume doesn't use RetroFW's volume #171

Open jaredreich opened 3 years ago

jaredreich commented 3 years ago

Hey! Quick question, I noticed that on some devices, like the RG-300, the volume wheel is very hard to adjust on lower volume settings, so I set the "Audio volume" to 1 in the RetroFW settings, which fixes the issue when loading an emulator from the RetroFW interface. But if I go into SimpleMenu and start up a game, the volume is back to 100. Might this be because of these lines: https://github.com/fgl82/simplemenu/blob/27d95ee78da3c8323aa208e9f96ae77cacddd1d7/simplemenu/src/logic/system_logic_rfw.c#L94-L96

Is there any way we can make SimpleMenu inherit the "Audio volume" setting from RetroFW rather than forcing it to 100%?

Thanks very much for reading!!!

fgl82 commented 3 years ago

Sure, I'll take a look

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jared Reich @.> Sent: Wednesday, July 7, 2021 5:08:24 PM To: fgl82/simplemenu @.> Cc: Subscribed @.***> Subject: [fgl82/simplemenu] Volume doesn't use RetroFW's volume (#171)

Hey! Quick question, I noticed that on some devices, like the RG-300, the volume wheel is very hard to adjust on lower volume settings, so I set the "Audio volume" to 1 in the RetroFW settings, which fixes the issue when loading an emulator from the RetroFW interface. But if I go into SimpleMenu and start up a game, the volume is back to 100. Might this be because of these lines: https://github.com/fgl82/simplemenu/blob/27d95ee78da3c8323aa208e9f96ae77cacddd1d7/simplemenu/src/logic/system_logic_rfw.c#L94-L96

Is there any way we can make SimpleMenu inherit the "Audio volume" setting from RetroFW rather than forcing it to 100%?

Thanks very much for reading!!!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/171, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHHEHG6KAARW2464D2LTWSX3RANCNFSM477KYWRQ.

jaredreich commented 3 years ago

You are so kind and responsive! Please let me know if you need help, I am also a developer but sadly not with the C language 😛

fgl82 commented 3 years ago

No problem, I'll change that and run some tests. I totally took that code from gmenu and never questioned it, as I usually play with headphones (through which the base volume is not bad at all) or in an environment where the base volume is not too loud for me. I don't like the menu messing with OS settings, so I'll try removing that and see how it works.

jaredreich commented 3 years ago

Very cool, thanks for your time in replying and trying this. I also hope you don't mind me bombarding your issues page with specific nitpicky stuff. My son and I are sooo enjoying SimpleMenu on our RG-300's and are just noticing these couple things. Cheers!!!

fgl82 commented 3 years ago

Haven't fixed this on the latest release (9.3), since it seems RFW initializes volume in 0, forcing me to define "something" or it won't have sound at all. I will define a new config for the next one so you can set it manually like you do in gmenu

jaredreich commented 3 years ago

Thanks so much for the follow up. That sounds like a great solution, really looking forward to using it!!

jaredreich commented 3 years ago

You've been doing awesome with simplemenu release lately man, great work! So excited for this volume config feature if you're able to find the solution. I think it's the last final piece to perfect the RG-300 device for me!

Cheers man! 🍻

fgl82 commented 3 years ago

I'll tackle that for the next version

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jared Reich @.> Sent: Monday, September 13, 2021 3:11:19 PM To: fgl82/simplemenu @.> Cc: FGL82 @.>; Comment @.> Subject: Re: [fgl82/simplemenu] Volume doesn't use RetroFW's volume (#171)

You've been doing awesome with simplemenu release lately man, great work! So excited for this volume config feature if you're able to find the solution. I think it's the last final piece to perfect the RG-300 device for me!

Cheers man! 🍻

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/171#issuecomment-918448781, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHB24ZTO43BW6QFAOKLUBY5EPANCNFSM477KYWRQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jaredreich commented 3 years ago

Sir, you are wonderful.

fgl82 commented 2 years ago

Sorry, this is still pending, still planning to work on it eventually.

jaredreich commented 2 years ago

No need to apologize. Thank you very much for the follow up response. Looking forward to it! Cheers!!!

jgferrer commented 2 years ago

@jaredreich I have modified SimpleMenu to add the ability to change the volume on RG300 (new option for SimpleMenu on Settings Screen). If you want to try you can download it at https://github.com/jgferrer/simplemenu/releases/tag/v.1.0 Create a backup of your SimpleMenu opk and replace it with the one in the link. It should work... It works for me, putting for example 10 or 20, sounds much lower than before :-)