search

fgm / filog

A fine logger package for Meteor.JS applications (client + server)
GNU General Public License v3.0
18 stars 6 forks source link

Fix disarm() #43

Closed arggh closed 3 years ago

arggh commented 6 years ago

The method in Logger that's subscribed to TraceKit's reporter is never removed from TraceKit's subscribed handles when calling disarm

This is because TK removes them via direct comparison, and the method given in Logger.disarm() is not equal to the one given in Logger.arm().

Fixed by using the same method in both cases.

arggh commented 6 years ago

@fgm did you by any chance have a look at this PR?

arggh commented 5 years ago

I'ts been a while, could you perhaps consider merging this or describe what should be changed?

fgm commented 5 years ago

Looks good to me. Can you:

Also this will need to be forward ported to the 0.2.x series over #67