search

fgmacedo / python-statemachine

Python Finite State Machines made easy.
MIT License
854 stars 84 forks source link

update a comment. #429

Closed NitaiP closed 4 months ago

NitaiP commented 4 months ago

I have added comments in a utility routine.

NitaiP commented 4 months ago

@fgmacedo - Thank you for approving it. I may continue to add more docstrings/comments in the near future.

It looks like one task, Upload coverage to Codecov in python 3.12 failed. What could be the reason? Do I need to do anything from my end? Thank you.

fgmacedo commented 4 months ago

@fgmacedo - Thank you for approving it. I may continue to add more docstrings/comments in the near future.

It looks like one task, Upload coverage to Codecov in python 3.12 failed. What could be the reason? Do I need to do anything from my end? Thank you.

Hi @NitaiP , I saw... I tried to re-run the workflow but without success. I'm working on this, I think that this can be a change on the Codecov side from yesterday. Trying to update the upload token secret, lets see if it works.

But there's something wrong not related to this PR.

fgmacedo commented 4 months ago

@NitaiP can you please rebase your PR over the develop branch? I've updated the codecov action on another PR and seems to have fixed the error: https://github.com/fgmacedo/python-statemachine/pull/430

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

NitaiP commented 4 months ago

@NitaiP can you please rebase your PR over the develop branch? I've updated the codecov action on another PR and seems to have fixed the error: #430

@fgmacedo - Done. Thanks.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (eb844e9) to head (04e52aa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #429 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 1174 1174 Branches 166 166 ========================================= Hits 1174 1174 ``` | [Flag](https://app.codecov.io/gh/fgmacedo/python-statemachine/pull/429/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Macedo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fgmacedo/python-statemachine/pull/429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Macedo) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Macedo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.