search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

. in bower package name breaks some grunt tasks. #257

Closed ascheucher closed 9 years ago

ascheucher commented 10 years ago

As it's common to name bower and npm packages like this: "my-long-name" and not like this "my.long.name", some tasks break on execution.

an example here is the grunt-rev task, which takes static files and prefixes them with a hash to easen browser caching.

it would be great to rename the packe from 'spin.js' to 'spin-js'.

Thanks, Andreas

ascheucher commented 10 years ago

Here as additional argument the naming specs for bower packages.

Greets, Andreas

MagicIndustries commented 10 years ago

I came here to post the same issue :) I resolved it by renaming everything to spinjs, so definitely +1 for the idea of renaming the package without a dot, for the sake of being able to keep it in my angular builds.

brandon-arnold commented 9 years ago

I also came upon rev crashing because it was trying to parse spin.js/, the FOLDER not the FILE.

fgnass commented 9 years ago

The use of dots is explicitly allowed in https://github.com/bower/bower.json-spec#name so even it might be uncommon or a bad practice it's still a perfectly valid package name. Please understand that I won't rename the package because of a buggy grunt plugin.

ascheucher commented 9 years ago

I see. I think, I mixed that up with the specifications of package names of npm. There for sure, a dot is not allowed. Sorry for the confusion.