search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

Make jquery plugin work with jshint. #298

Closed tjgupta closed 9 years ago

fgnass commented 9 years ago

It already validates, you just have to use the project's local .jshintrc file.

tjgupta commented 9 years ago

Ah I see. I don't think most people would agree that the "relaxing" options in the .jshitrc are a good thing. I'd suggest removing those and still taking most of these changes. For example not requiring semicolons seems really sloppy and error-prone to me (not to mention inconsistent, as some particular places they are still required to make the code do what you need it to do).

I'd be happy to try to adjust this PR with that change to the .jshintrc and all the JS, but I won't bother if you think using ASI is a good thing and don't want to change that. Let me know.

fgnass commented 9 years ago

I'm not religious about a particular coding style, but would prefer to keep this project as it is. It by the way uses the same style as npm which also roughly equals feross' JavaScript Standard Style.