search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

Update UMD Shim to be resilient to HTMLElement global pollution #300

Closed mikesherov closed 9 years ago

mikesherov commented 9 years ago

Please see https://github.com/umdjs/umd/pull/63/files and https://github.com/umdjs/umd/issues/35 for more information, but this change prevents an HTML element with an id of module from cuasing the UMD shim to incorrectly detect the enivornment as node.

fgnass commented 9 years ago

I'm currently not near any computer (and won't be so for the next week) but maybe @TimothyGu can cut a new release?

mikesherov commented 9 years ago

That would be fantastic! I appreciate the quick movement here.

TimothyGu commented 9 years ago

@mikesherov, done. Sorry about the wait.

mikesherov commented 9 years ago

No worries! Thanks for the bump and helping out!