search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

Use external CSS file to support keyframe animations with strict content security policy #347

Closed theodorejb closed 6 years ago

theodorejb commented 6 years ago

Adds a new animation option to choose a CSS animation name, and removes the opacity and trail options. There is now a spin.css file that can be included to use one of the preset animations.

Since IE 9 doesn't support keyframe animations, this pull request drops support for it, and also removes the fps option which was only used for IE 9.

Fixes #106, closes #215.

theodorejb commented 6 years ago

The only serious blocker I know of is that Microsoft Edge doesn't use the correct duration for fading out the spinner lines. I filed an issue for this here: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/14931071/.

theodorejb commented 6 years ago

The Microsoft Edge bug is fixed in the Windows 10 April 2018 update (version 1803), so there's nothing blocking this anymore.