search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

Add webkit prefix for Chrome under 36 #350

Closed congjiujiu closed 6 years ago

congjiujiu commented 6 years ago

Add '-webkit' prefix for 'transform' properties so that spin.js can work at low version of Chrome(< 36)

congjiujiu commented 6 years ago

Demo is here demo

and you can open this site on Chrome 35 or before

theodorejb commented 6 years ago

Why would you need to support a Chrome version that is almost 4 years old (Chrome 35 was released in May 2014)? Anyone using such an old version is likely exposing themselves to all sorts of security vulnerabilities.

If you need support for really old browsers, it might be better to stick with spin.js 2.x.

congjiujiu commented 6 years ago

@theodorejb Oh，there are still so many people using IE 6 in my country... So many of our projects must support old version browsers. And there are some codes for IE 9 in spin.js , so I think maybe we could add supports just for transform properties so that I can use spin.js in my project.

theodorejb commented 6 years ago

@congjiujiu Chrome is quite different from old IE versions, though, since it has always auto-updated. Old versions of Chrome have minuscule usage compared to old versions of Internet Explorer.

congjiujiu commented 6 years ago

@theodorejb Fine, but the users from Chinese banks, or government department are prevented from upgrading their browsers, they are stuck with older version of Chrome. And I believe that they need spin.js.

theodorejb commented 6 years ago

Closing since spin.js v4 drops support for IE 9 (and thus the vendor function has been removed). Again, if you need to support these very old browsers I would recommend sticking with spin.js 2.x.