search

fgnass / spin.js

A spinning activity indicator
http://spin.js.org
MIT License
9.3k stars 1.02k forks source link

Changes for high contrast mode #377

Open pratikgolchha opened 4 years ago

pratikgolchha commented 4 years ago

Changes for high contrast mode. Spinner is not visible in high contrast mode

pratikgolchha commented 4 years ago

@fgnass @theodorejb Please review this PR

theodorejb commented 4 years ago

@pratikgolchha Have you tested this? The property value needs to be a string. Also, the transparent border seems to cause an issue where setting line length to 0 and corners to 1 no longer results in perfectly round circles.

pratikgolchha commented 4 years ago

@theodorejb I have removed the border and applied it only in high contrast mode.

theodorejb commented 4 years ago

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast has the following warning:

This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user.

Also, were you able to get it working? For me the style applied when not in the media query, but when in the media query it didn't apply even when high contrast mode was active (tested in IE 11 and Edge 18).