fgnt / nara_wpe

Different implementations of "Weighted Prediction Error" for speech dereverberation
MIT License
474 stars 165 forks source link

Syntax error in nara_wpe/utils.py", line 204 #37

Closed Sciss closed 4 years ago

Sciss commented 4 years ago

I get this when trying to run the first cell from WPE_Numpy_offline:

  File "/home/hhrutz/Documents/devel/nara_wpe/nara_wpe/utils.py", line 204
    *,
     ^
SyntaxError: invalid syntax

What do to?

Screenshot from 2019-11-24 23-55-16

Sciss commented 4 years ago

It seems the notebooks must be run with Python3 kernel. I also needed to manually install scipy and matplotlib packages, seems a missing dependency declaration of nara_wpe.

LukasDrude commented 4 years ago

Dear Hanns,

according to Travis all tested code runs on Python 2.7, 3.5, and 3.6: https://travis-ci.org/fgnt/nara_wpe

I think we will add a small hint that the notebooks might require 3.5 somewhere.

My recommendation in general is to use a separate Python environment (e.g. via an Anaconda distribution) if you try using Nara-WPE in a research context. If you want to write an application using Nara-WPE you might want to run this with system Python 3, but we did not test that explicitly.

Regarding the dependencies: The core code does not have this dependencies. Thus, we tried to make the dependency list as short as possible.

Hope this helps.