Closed michael-kuhlmann closed 1 year ago
If you do not like to have the contrib commits in this PR, I can first merge the contrib changes and then create a new clean PR for this issue.
If you do not like to have the contrib commits in this PR, I can first merge the contrib changes and then create a new clean PR for this issue.
We can use one PR to merge both. It is unlikely, that we have second PR, that should be merged before your praat-textgrids
code.
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
2a4c391
) 77.12% compared to head (dc9f016
) 77.12%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I have added python 3.9 and 3.10 and adapted two doctests to work with the latest versions of torch and python:
torch 2.0.1
) behave non-deterministically when using packed vs. non-packed input. He suggested to fix the doctest by replacing the test for strict equality with an allclose
test. I increased the atol
argument to 1e-6 as the max observed absolute difference between the outputs was around 6e-7kw_only
attribute for dataclasses which appears in the expected error message for Python 3.10 but not for Python<=3.9. Since we are only testing for the occurrence of the RunTimeError, I have added an ellipsis where the kw_only
attribute would appear.LGTM. The azure tests can be ignored, they got somehow canceled.
GitHub actions currently do not pass because pb_bss cannot be successfully installed due to an old version of setuptools that is used. This pull request fixes this and upgrades the action versions of checkout and setup-python.