search

fgnt / pb_bss

Collection of EM algorithms for blind source separation of audio signals
MIT License
265 stars 60 forks source link

Making evaluation a separated package #10

Closed mpariente closed 4 years ago

mpariente commented 4 years ago

Would you consider making pb_bss.evaluation a standalone python package?

LukasDrude commented 4 years ago

Dear Manuel,

we think that pb_bss is already a rather small package. We can offer to remove more of the dependencies in setup.py. Other than that, especially for multi-channel source separation/ extraction there might be more connection points where your repository may import from pb_bss.

What do you think?

Lukas

mpariente commented 4 years ago

Thanks for you quick answer Lukas ! I'll probably try to integrate it into asteroid, thanks

mpariente commented 4 years ago

Could you provide installation instruction please? Are there some know issues with Cython? I cannot compile the files

boeddeker commented 4 years ago

I will add some installation instructions. We do not know a problem with Cython, but we haven't tested it on windows. Could you tell me more about the error message?

LukasDrude commented 4 years ago

Dear Manuel,

following up with Christoph's answer, let us try to make it possible to import the metrics from pb_bss. We can definitely reduce dependencies from our side and, if needed, make it a PyPi package.

Lukas

mpariente commented 4 years ago

After installing numpy and Cython with pip, I run pip install -e . and it doesn't work (the stacktrace is huge, I can create another issue for it).

After commenting out these lines in the setup.py, it works. After that, I can uncomment the same lines and run pip install -e . again and this works (I can import the _c* function from extraction after that), it's a weird one !