corrected case of independent dimension

fgnt / pb_bss

Collection of EM algorithms for blind source separation of audio signals

MIT License

265 stars 60 forks source link

corrected case of independent dimension #5

Closed TCord closed 5 years ago

TCord commented 5 years ago

support of larger than one independent dimension Signed-off-by: Tobias Cord-Landwehr cord@mail.upb.de

LukasDrude commented 5 years ago

Great contribution. Can you add/ change a test case which verifies that your solution is indeed correct?

TCord commented 5 years ago

The modified test now avoids the case with an independent dimension size of one. The previous version only allowed this independent dimension size due to fixed dimensions in the gaussian distribution.

LukasDrude commented 5 years ago

Ok. Perfect. Thank you for your contribution.