fgouteroux / terraform-provider-loki

This terraform provider allows you to interact with grafana loki.

https://registry.terraform.io/providers/fgouteroux/loki/latest/docs

Apache License 2.0

4 stars 3 forks source link

docs: added examples for multi rules definition in rule_group_recording/alerting #2

Closed anthonygauthier closed 4 months ago

anthonygauthier commented 4 months ago

Hi, first of all thanks for this provider, comes in really handy 😄 !

Description

This PR provides examples on how to define multiple rules in the loki_rule_group_recording and loki_rule_group_alerting resources.

fgouteroux commented 4 months ago

Hi @anthonygauthier because TypeSet is unordered it's hard to get a clear diff of what changes inside a rule. This is why I don't choose it.

anthonygauthier commented 4 months ago

@fgouteroux That makes perfect sense and I just realized I was doing something wrong in my own templated TF files 🤦. The provider is behaving as expected, I still think keeping the updated docs with multiple rules defined provides users with good examples though so I'll update my PR to just include that instead.

anthonygauthier commented 4 months ago

@fgouteroux There we go; sorry about this - hope the docs is appreciated anyways 😄 !

fgouteroux commented 4 months ago

@anthonygauthier Yes I accept the doc update (you also fix the missing EOT). Thanks