If you were to publish this manually via ArcMap, you would receive an error about these characters. In order to avoid potential problems, modify the logic to avoid using hyphens (underscores instead?) in the service names.
This was previously brought up by Christ Thorne from the ECDMP team in IMD.
By default, services are published using their full UUIDs which contain several hyphens, e.g.: http://ec.gc.ca/arcgis/rest/services/data/28cf0e45-2aa2-4015-a5a0-5808a98dfd95/MapServer
If you were to publish this manually via ArcMap, you would receive an error about these characters. In order to avoid potential problems, modify the logic to avoid using hyphens (underscores instead?) in the service names.
This was previously brought up by Christ Thorne from the ECDMP team in IMD.