search

fgpv-vpgf / rcs

RAMP Configuration Service
http://fgpv-vpgf.github.io/rcs
1 stars 8 forks source link

refactor(update): Refactored v2 Update endpoint #62

Closed dan-bowerman closed 7 years ago

dan-bowerman commented 7 years ago

RCS v2 now supports the ability to update specific fields in a previous registration, without re-registering wholesale. WMS registrations will also store whether a layer is queryable or not. The refactor also resolves an issue where feature_info_format in WMS layers was not being set.

Closes #59, #60

This change is Reviewable

glitch-bot commented 7 years ago

You forgot to assign your PR! It's a muffin offence, you know...

alyec commented 7 years ago

Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

_setup.py, line 10 at r1 (raw file):_

    name="rcs",
    description="RAMP Configuration Service",
    version="2.2.1",

When the package version updates the docs config needs to be updated as well: https://github.com/fgpv-vpgf/rcs/blob/develop/docs/conf.py#L61

Comments from Reviewable

alyec commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

_Comments from Reviewable_

AleksueiR commented 7 years ago

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

dan-bowerman commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

_setup.py, line 10 at r1 (raw file):_

Previously, alyec (Aly Merchant) wrote… > When the package version updates the docs config needs to be updated as well: https://github.com/fgpv-vpgf/rcs/blob/develop/docs/conf.py#L61 >

Done.

Comments from Reviewable