IE11: Object doesn't support this action - Event constructor fix

fgr-araujo / vue-shortkey

Vue-ShortKey - The ultimate shortcut plugin to improve the UX

MIT License

889 stars 101 forks source link

IE11: Object doesn't support this action - Event constructor fix #80

Closed mdix closed 5 years ago

mdix commented 5 years ago

IE11 doesn't allow the usage of Event as a constructor, resulting in the following error:

Screenshot 2019-04-09 at 08 03 51

I added a polyfill for CustomEvent and used this instead of Event. I tested with Safari 12.0.3 (Mac), Firefox (latest Mac), Chrome (latest Mac) and IE11 (Win 7) and found no issues.

Note: All browsers that support CustomEvent natively use their native CustomEvent constructor.

mdix commented 5 years ago

Hey,

anyone up for this? I'd really like to get it merged, so just gimme some lines if something isn't right. I'm willing to put some more time into this, if necessary.

Best Marc

fgr-araujo commented 5 years ago

Great work budy! Sorry for latest merge, i'm very busy last days.

Merged! I will bump the version