search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
711 stars 111 forks source link

Explicit `Letter` class for avoiding name conflict #108

Closed shishi closed 2 years ago

shishi commented 3 years ago

I installed letter_opener_web in my rails app, I found conflicting Letter class with my own Letter class.

I'd like to explicit Letter class's name space in letter_opener_web. If there is other solutions without changing letter_opener_web, I'd like to choose that.

shishi commented 3 years ago

It seem this failed lint didn't occur from my change. But if you want to fix in this PR, I can.

fgrehm commented 2 years ago

Hey @shishi, just a heads up that this is something that will come along with the upcoming 2.0 I got in the works, see the PR linked above for more.

If you have the time, it'd be great if you could give that branch a try as well, tks in advance!

fgrehm commented 2 years ago

Just got a pre-release ready to go. Please give that a try when you get a chance and I'll also just ping more folks for testing before a final release. This PR should auto close after code is on master.

Thanks for your contribution!