search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
718 stars 112 forks source link

Missing gem dependency on rexml #109

Closed mostlyobvious closed 3 years ago

mostlyobvious commented 3 years ago

I've noticed that rexml is a required gem: https://github.com/fgrehm/letter_opener_web/blob/968d1a0c3ff679fdfabdd2b449b6573e992b4c64/lib/letter_opener_web.rb#L4

Yet it is not mentioned as a runtime dependency in gemspec: https://github.com/fgrehm/letter_opener_web/blob/968d1a0c3ff679fdfabdd2b449b6573e992b4c64/letter_opener_web.gemspec#L23-L25

Is it intentional?

If not, perhaps it went unnoticed because development dependencies bring it to the load path.

mostlyobvious commented 3 years ago

Sorry, just noticed https://github.com/fgrehm/letter_opener_web/pull/106

fgrehm commented 3 years ago

Hey @pawelpacana! yeah, #106 is going in with https://github.com/fgrehm/letter_opener_web/pull/113