Closed fgrehm closed 2 years ago
Merging #113 (19955da) into master (968d1a0) will increase coverage by
0.36%
. The diff coverage is96.92%
.
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 97.31% 97.68% +0.36%
==========================================
Files 23 7 -16
Lines 335 302 -33
==========================================
- Hits 326 295 -31
+ Misses 9 7 -2
Impacted Files | Coverage Δ | |
---|---|---|
app/models/letter_opener_web/letter.rb | 91.89% <90.47%> (-1.10%) |
:arrow_down: |
...ollers/letter_opener_web/application_controller.rb | 100.00% <100.00%> (ø) |
|
...ontrollers/letter_opener_web/letters_controller.rb | 96.87% <100.00%> (-3.13%) |
:arrow_down: |
...llers/letter_opener_web/letters_controller_spec.rb | 100.00% <100.00%> (ø) |
|
spec/letter_opener_web_spec.rb | 100.00% <100.00%> (ø) |
|
spec/models/letter_opener_web/letter_spec.rb | 100.00% <100.00%> (ø) |
|
config/routes.rb | ||
lib/letter_opener_web.rb | ||
lib/letter_opener_web/delivery_method.rb | ||
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c19a7f4...19955da. Read the comment docs.
Thanks, @fgrehm for your great work. I use 2.0.0.pre.alpha1 in my application, and it seems be working fine for me 😄
I'm waiting for a stable release 🚢
Thanks @tricknotes! I think we're very close to a final release, there's just one thing @dee-see found that I'd like to do before that :crossed_fingers:
@fgrehm I used new revision in my sample application(https://github.com/ihatov08/letter_opener_web_rails_api), csrf error didn't occur.(and flash error didn't occur) Thank you for fixed errors. It looks good!
Thanks @ihatov08! I'm going to go ahead and cut the final release now :tada:
TL;DR
This is a 8+yr old gem, it's time for a new major release and some breaking changes. We also need to give some love to the UI since it hasn't changed at all since the very first release.
How to test?
Set the gem to the new pre-release version:
Then
bundle install
, restart your app and head over to the app's inbox (ex: http://localhost:3000/inbox) and you'll get the new release :tada:New look
TODO
v1-stable
branch with what's on master