search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
711 stars 111 forks source link

refactor: fix_link_html #122

Open izumiiii opened 2 years ago

izumiiii commented 2 years ago

What

https://github.com/fgrehm/letter_opener_web/issues/121 refactoring fix_link_html method

How to test

executed bundle exec rspec

fgrehm commented 2 years ago

Thanks, I'll try to merge it in this week

fgrehm commented 2 years ago

The lint failure is unrelated to your change, I'll take a look at fixing it on master

stevenharman commented 4 months ago

👋 Hello @izumiiii! Thanks for the PR.

It looks like the change here is switching to a ternary, yes? Is there some other behavior change I'm not seeing?