search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
719 stars 113 forks source link

Remove deprecated calls to routing mapper #141

Closed etiennebarrie closed 3 months ago

etiennebarrie commented 3 months ago

See https://github.com/rails/rails/pull/52422

stevenharman commented 3 months ago

Thanks for the contribution, @etiennebarrie. If I'm following the linked PRs correctly, this deprecation won't take place until Rails 8.0. And the keyword based API (using to: and at:) has been supported for… a long time! Meaning our existing dependency constraints on railties >= 6.1 should be fine.

If all of that is correct, this is 👍 for me.

etiennebarrie commented 3 months ago

Oh sorry I forgot to add some details. Yes this is what I found as well, to:, at: have been here for a long time, no risk on backwards compatibility. 👍

Yes Rails 8.0 will deprecate this syntax. Some of us run Rails main in production 😇