search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
718 stars 112 forks source link

Change rails dependency to >= 3.2 #15

Closed joejwright closed 11 years ago

joejwright commented 11 years ago

I just tested this with rails 4.0.0 and everything looks fine.

fgrehm commented 11 years ago

@jwrigh13 it's good to know that it works! we just need to fix the specs before merging in. I'm heading on vacation today for a week but will have a look at it once I'm back :) thanks!

zealoushacker commented 11 years ago

Also, why would you guys require rails dependency to be >= 3.2, when it's backwards compatible with older rails versions? I just got this while trying to bundle install letter_opener_web in a rails 3.0.19 app, to fix the vagrant-related issues:

Bundler could not find compatible versions for gem "rails":
  In snapshot (Gemfile.lock):
    rails (3.0.19)

  In Gemfile:
    letter_opener_web (~> 1.0.3) ruby depends on
      rails (~> 3.2) ruby

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
zealoushacker commented 11 years ago

Ah, I think 3.1.0 would be minimum, due to usage of some methods like isolate_namespace

zealoushacker commented 11 years ago

Never mind, looks like 3.2.0 would be required due to some other dependencies :(

All good, :+1:

fgrehm commented 11 years ago

@zealoushacker MERGED! tks for the help :) the new version will be available on rubygems in a few