search

fgrehm / letter_opener_web

A web interface for browsing Ruby on Rails sent emails
MIT License
718 stars 112 forks source link

Mounting Letter_Opener overrides any authentication #43

Closed Meatballs1 closed 6 years ago

Meatballs1 commented 9 years ago

It looks like the default ApplicationController bundled in app/controllers overrides the target rails project ApplicationController. Therefore even if you have a default authentication method in your project's ApplicationController you can still browse directly to /letter_opener without authenticating.

:(

Meatballs1 commented 9 years ago

I'm thinking this may just be an underlying issue with Rails Engines: http://jacopretorius.net/2012/12/authenticating-rails-engines-with-devise.html

sobrinho commented 9 years ago

If you want to authenticate the access to /letter_opener, I think you are looking for route constraints :)

pseudomuto commented 6 years ago

This is very old at this point and has no recent activity. I'm going to close it for now. Feel free to open a new issue/PR if this is still a concern.