fgrehm / vagrant-cachier

Caffeine reducer
http://fgrehm.viewdocs.io/vagrant-cachier
MIT License
1.08k stars 111 forks source link

Remove chmod 777 for cifs mounted folders #107

Closed withinboredom closed 10 years ago

withinboredom commented 10 years ago

Vagrant fails on

The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mkdir -p /tmp/vagrant-cache && chmod 777 /tmp/vagrant-cache

Stdout from the command:

Stderr from the command:

stdin: is not a tty
chmod: changing permissions of ���/tmp/vagrant-cache���: Permission denied

This is due to the fact that you cannot chmod an smb folder. File permissions are set at mount time with options

mount_options: ["file_mode=0777", "dir_mode=0777"]

This may be for another ticket, but is 777 really necessary for package storage?

fgrehm commented 10 years ago

The chmod 777 was introduced on https://github.com/fgrehm/vagrant-cachier/commit/0dd1b20053a35ce6ee9ef92152e01eb33cf341df in order to fix GH-74 so I'm not sure if we can get rid of that.

Which provider are you using over there? We might be able to change the code to skip the chmod if an specific synced folder implementation or provider gets detected.

withinboredom commented 10 years ago

I'm using hyperv— Sent from Mailbox

On Mon, Jun 23, 2014 at 10:02 PM, Fabio Rehm notifications@github.com wrote:

The chmod 777 was introduced on https://github.com/fgrehm/vagrant-cachier/commit/0dd1b20053a35ce6ee9ef92152e01eb33cf341df in order to fix GH-74 so I'm not sure if we can get rid of that.

Which provider are you using over there? We might be able to change the code to skip the chmod if an specific synced folder implementation or provider gets detected.

Reply to this email directly or view it on GitHub: https://github.com/fgrehm/vagrant-cachier/issues/107#issuecomment-46924402

fgrehm commented 10 years ago

This was fixed in git, a new release will come out with it as soon as I'm done with the stuff tagged with the v1.0.0 milestone