fgrehm / vagrant-cachier

Caffeine reducer
http://fgrehm.viewdocs.io/vagrant-cachier
MIT License
1.07k stars 111 forks source link

Mistakenly made small change directly on master from web UI :/ #149

Closed patcon closed 9 years ago

patcon commented 9 years ago

Ack. Grrr... Sorry guys. I forgot a had push access here, and was thinking I was submitting a simple change via PR in the web UI :/

https://github.com/fgrehm/vagrant-cachier/commit/dd32f2472e60af948d2c36033b122acd7065f9f3

Should I revert and resubmit in a PR, or is this small enough to leave it, despite the faux pas?

fgrehm commented 9 years ago

I'm cool with keeping it around but since I'm not actively using the plugin I'd recommend trying to get someone else to try it out before :ship: ing it! :smile:

patcon commented 9 years ago

:+1: Thanks fabio :)

patcon commented 9 years ago

Despite my "oops I fucked up", would you be comfortable giving me rubygems access to a can push out a new release?

EDIT: haha. oh. such speedy action, @fgrehm ;) https://rubygems.org/profiles/patcon

fgrehm commented 9 years ago

:shipit: