search

fgrehm / vagrant-cachier

Caffeine reducer
http://fgrehm.viewdocs.io/vagrant-cachier
MIT License
1.08k stars 111 forks source link

Composer cache #50

Closed fgrehm closed 10 years ago

fgrehm commented 10 years ago

Superseeds https://github.com/fgrehm/vagrant-cachier/pull/48 by adding a check whether PHP is installed prior to configuring the new bucket.

BTW I didn't update the CHANGELOG just to avoid potential merge conflicts with GH-47, but will do that as soon as this gets merged :P

/cc @patcon @fh

patcon commented 10 years ago

Haven't tested, but :+1: to premise.

Perhaps we could open another stub for later to accommodate these considerations: http://getcomposer.org/doc/04-schema.md#config (cache-dir) http://getcomposer.org/doc/03-cli.md#composer-home

And also, perhaps after the first run we could take this into account:

composer config --global cache-dir

To clarify, I certainly don't think this stuff is worth holding anything up, but might be nice to keep track of it in another issue. That way, if anyone runs into an issue, there's a thread to follow. If that sounds ok, just say so and I'll create that :)

fgrehm commented 10 years ago

@patcon cool, I'll merge this in and will handle the release, thanks for having a look at it :)

@fh thanks for helping out and welcome aboard :)

fgrehm commented 10 years ago

@patcon Oh, just to save you some time I created GH-52 ;)

patcon commented 10 years ago

haha :+1:

fh commented 10 years ago

Yay! :fireworks: