search

fgrehm / vagrant-cachier

Caffeine reducer
http://fgrehm.viewdocs.io/vagrant-cachier
MIT License
1.08k stars 111 forks source link

Make menu links relative #65

Closed marksteve closed 10 years ago

marksteve commented 10 years ago

Not sure when fixes will be deployed to viewdocs.io though :smile:

marksteve commented 10 years ago

Seems like it has been deployed :smile:

fgrehm commented 10 years ago

@marksteve thank you for taking the time to put up this PR and fixing the issue on viewdocs, but unfortunately I think the changes over there are not 100% right yet :(

If you go to http://marksteve.viewdocs.io/vagrant-cachier~docs/buckets/pacman and try to use any of the links from the menu, you'll notice that they start breaking as they get the buckets prepended to them (like in http://marksteve.viewdocs.io/vagrant-cachier~docs/**buckets**/usage)

I'll try to dig into that now so I think I'll hold back on this PR for a bit but thanks a lot for putting it up :)

fgrehm commented 10 years ago

I sent a PR that has been merged on viewdocs and deployed already and this works fine now.

@marksteve thanks!