search

fgrehm / vagrant-cachier

Caffeine reducer
http://fgrehm.viewdocs.io/vagrant-cachier
MIT License
1.08k stars 111 forks source link

README.md - conditional plugin specific configs #75

Closed tuminoid closed 10 years ago

tuminoid commented 10 years ago

Wrap plugin specific configs into has_plugin checks to avoid breakage when Vagrantfile is shared and/or plugin is removed (for testing/development).

tmatilai commented 10 years ago

Maybe also to the docs site (sources).

tuminoid commented 10 years ago

Good catch @tmatilai, updated the other docs and added a little explanation.

Generally, I've tried to add the has_plugin? to the major examples, and not every little snippet, since it'll quickly make them look messy.

tmatilai commented 10 years ago

Looks great to me! Just one more thing. You have wrapped also the config.vm.box definition inside the if block. If you fix that (and maybe even rebase all changes to only one commit), I would be ready to merge this as I've understood that @fgrehm is enjoying his earned vacations. =)

tuminoid commented 10 years ago

Another good catch. This is what you have when you try update via web interface to enjoy preview instead of doing it properly via command line :-)

tmatilai commented 10 years ago

Heh, yeah. There are many markdown editors/viewers that might help there. =)

But this looks good to me, so I'll merge it.

fgrehm commented 10 years ago

:thumbsup: :beers: