fgrosse / go-coverage-report

A CLI tool and GitHub Action to post Go code coverage reports as comment to your pull requests.
BSD 3-Clause "New" or "Revised" License
59 stars 11 forks source link

Looking for artifact to fetch is too strict #19

Closed piotrowski closed 6 months ago

piotrowski commented 6 months ago

Hello! Great action, but I noticed small issue that breaks my setup :D

You are doing this in action:

gh run list --status=success --branch=main '--workflow=Lint and Test' --event=push --json=databaseId --limit=1 -q '.[] | .databaseId'

However in setup I am not using I only run job on cron-schedule, so I do not have --event=push there at all. Is this option configurable maybe?

PS: I know I will lose some accuracy here because of that :sweat:

piotrowski commented 6 months ago

Ok, after creating this issue and thinking it through. It does not make sense to use this action without running test on push :P Closing :)