search

fgrosse / go-coverage-report

A CLI tool and GitHub Action to post Go code coverage reports as comment to your pull requests.
BSD 3-Clause "New" or "Revised" License
53 stars 8 forks source link

deleted files not counted in all_changed_files.json #35

Closed jshufro closed 1 month ago

jshufro commented 1 month ago

Discovered while working on https://github.com/fgrosse/go-coverage-report/issues/34 that I can straight delete a test file and no coverage comment is generated.

This is because tj-actions/changed_files specifically excludes deleted files from the all_changed_files json: image

all_modified_files includes the deletions, and makes it so we correctly detect decreased coverage from deleting tests.

Working on a PR alongside the above issue.

fgrosse commented 1 month ago

Good catch!